🌱 Test ORC upgrades in e2e #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

k8s-ci-robot merged 1 commit into kubernetes-sigs:main from Nordix:siiri/orc_upgrades_e2e

Jun 24, 2025

Contributor

sirpaleet commented Jun 18, 2025 •

edited by lentzi90

Loading

What this PR does / why we need it:
Test ORC upgrades in e2e.

Which issue(s) this PR fixes:
Fixes #2568

Special notes for your reviewer:

Edits e2e tests.

TODOs:

squashed commits
if necessary:
- includes documentation
- adds unit tests

/hold

github-project-automation bot added this to CAPO Roadmap

k8s-ci-robot added the do-not-merge/hold label

github-project-automation bot moved this to Inbox in CAPO Roadmap

k8s-ci-robot added the do-not-merge/work-in-progress label

netlify bot commented Jun 18, 2025 •

edited

Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`54f93d4`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68591cfff350b80008ae18ea
😎 Deploy Preview	https://deploy-preview-2601--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot added the cncf-cla: yes label

k8s-ci-robot requested review from EmilienM and lentzi90

June 18, 2025 12:52

k8s-ci-robot added size/M needs-ok-to-test labels

Contributor

k8s-ci-robot commented Jun 18, 2025

Hi @sirpaleet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Contributor Author

sirpaleet commented Jun 18, 2025

/test ?

Contributor

k8s-ci-robot commented Jun 18, 2025

@sirpaleet: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Contributor

lentzi90 commented Jun 19, 2025

/ok-to-test

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels

lentzi90 reviewed

View reviewed changes

test/infrastructure/openstack-resource-controller/config/upgrade-from/kustomization.yaml Outdated Show resolved Hide resolved

Contributor Author

sirpaleet commented Jun 19, 2025

/test ?

Contributor

k8s-ci-robot commented Jun 19, 2025

@sirpaleet: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-openstack-build

/test pull-cluster-api-provider-openstack-e2e-test

/test pull-cluster-api-provider-openstack-test

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-openstack-conformance-test

/test pull-cluster-api-provider-openstack-e2e-full-test

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-openstack-build

pull-cluster-api-provider-openstack-e2e-test

pull-cluster-api-provider-openstack-test

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lentzi90 reviewed

View reviewed changes

test/e2e/data/e2e_conf.yaml Outdated Show resolved Hide resolved

Contributor

lentzi90 commented Jun 19, 2025

The relevant test for the upgrade is pull-cluster-api-provider-openstack-e2e-full-test when you feel ready 🙂

sirpaleet force-pushed the siiri/orc_upgrades_e2e branch from 32ec000 to 2a258e6 Compare

June 19, 2025 06:37

Contributor Author

sirpaleet commented Jun 19, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

1 similar comment

Contributor

lentzi90 commented Jun 19, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

sirpaleet force-pushed the siiri/orc_upgrades_e2e branch 2 times, most recently from d39d851 to ec6cd9b Compare

June 23, 2025 07:10

Contributor Author

sirpaleet commented Jun 23, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

sirpaleet force-pushed the siiri/orc_upgrades_e2e branch from ec6cd9b to 75c35db Compare

June 23, 2025 08:59

Contributor Author

sirpaleet commented Jun 23, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test


          Test ORC upgrades in e2e

54f93d4

Signed-off-by: Siiri Kemppainen <siiri.kemppainen@est.tech>

sirpaleet force-pushed the siiri/orc_upgrades_e2e branch from 75c35db to 54f93d4 Compare

June 23, 2025 09:23

Contributor Author

sirpaleet commented Jun 23, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

Contributor Author

sirpaleet commented Jun 23, 2025

The test passed but brought up some fails with pod watching and UnhandledError related to clusterctl-upgrade and reflector.go, looking into it.

sirpaleet marked this pull request as ready for review

June 23, 2025 11:42

k8s-ci-robot removed the do-not-merge/work-in-progress label

k8s-ci-robot requested a review from mdbooth

June 23, 2025 11:43

Contributor Author

sirpaleet commented Jun 23, 2025

The test passed but brought up some fails with pod watching and UnhandledError related to clusterctl-upgrade and reflector.go, looking into it.

This seems to relate to lost connection and should not be because of these changes.

lentzi90 reviewed

View reviewed changes

Contributor

lentzi90 left a comment

Thank you!
It looks like it is working now. I can see the older version used for init and then the newer version installed during clusterctl upgrade. 👍
/approve

Contributor

k8s-ci-robot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the approved label

Contributor

lentzi90 commented Jun 24, 2025

/lgtm
/hold cancel

k8s-ci-robot removed the do-not-merge/hold label

k8s-ci-robot assigned lentzi90

k8s-ci-robot added the lgtm label

k8s-ci-robot merged commit 57ae27e into kubernetes-sigs:main

10 checks passed

github-project-automation bot moved this from Inbox to Done in CAPO Roadmap

mandre reviewed

View reviewed changes

Contributor

mandre left a comment

Sweet, thanks! I'm a little late to the party but you get my lgtm too 😃

lentzi90 deleted the siiri/orc_upgrades_e2e branch

June 24, 2025 09:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cncf-cla: yes lgtm ok-to-test size/M